-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(themes): add modus vivendi theme(s) #8894
Conversation
21c6f80
to
5a8879c
Compare
Thank you for Prot's great themes. I've been craving Ef-themes and was looking into implementing them, would you happen to know if the structure is the same as modus operandi and vivendi? |
@atahrijouti looking at https://github.com/protesilaos/ef-themes/blob/main/ef-dark-theme.el they should have the same structure. I tried it out here: https://github.com/matoous/helix/tree/md/ef-themes. Result: It might need some more adjustments. For example |
That's really cool. Thanks :-) |
Could you add the license for these (https://protesilaos.com/emacs/modus-themes#h:b14c3fcb-13dd-4144-9d92-2c58b3ed16d3) following the new notes from #8861? That should make it easier to package downstream (fedora for example) |
@the-mikedavis added, thanks! I missed that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to cut down on the duplication by using theme inheritance? It looks like most of the color names are the same so the variants could inherit the base theme and change the palette. See the gruvbox themes for an example
@the-mikedavis done, thanks. |
I would advocate to define also the highlights for the bufferline: "ui.bufferline" = { bg = "bg-tab-bar" }
"ui.bufferline.active" = { bg = "bg-tab-current", fg = "fg-mode-line-active" } |
@saccarosium updated, thanks! |
3836747
to
c2d9f8a
Compare
c2d9f8a
to
f90c9db
Compare
Add themes based on the dark variants of the modus themes (built-in with Emacs). This PR goes in line with #8728 and implements modus vivendi (dark) theme; reusing the original color palette.
modus_vivendi
modus_vivendi_tritanopia
modus_vivendi_deuteranopia
modus_vivendi_tinted
See Modus Themes Pictures for original.
Potentially more themes could be added in the future: https://protesilaos.com/emacs/ef-themes